add R matplotlib and full pack of interpreters#28
add R matplotlib and full pack of interpreters#28zhengkai6 wants to merge 2 commits intodylanmei:masterfrom
Conversation
ex00
left a comment
ex00
left a comment
There was a problem hiding this comment.
Hi @xixikaikai, thanks for your contribute.
I left some commets in review. General, I'm not shure about all changes in this PR.
First at all, I assume that use prebuild zepplelin dist not better that build zeppelin in image, because, for example some zeppelin vesrion doesn't store in official repositories. I could find only 0.8.0 version.
Next point, the PR contains many extra comment lines.
|
|
||
| #ARG DIST_MIRROR=http://archive.apache.org/dist/zeppelin | ||
| # use internal mirror of ustc | ||
| ARG DIST_MIRROR=http://mirrors.ustc.edu.cn/apache/zeppelin |
There was a problem hiding this comment.
better use close mirror for dowload. for example:
https://www.apache.org/dyn/closer.cgi?filename=zeppelin/zeppelin-0.8.0/zeppelin-0.8.0.tgz&action=download
| # RUN mkdir -p /tmp/zeppelin | ||
| RUN mkdir -p $ZEPPELIN_HOME | ||
| #RUN wget ${DIST_MIRROR}/zeppelin-${VERSION}/zeppelin-${VERSION}-bin-all.tgz | tar xvz -C ${ZEPPELIN_HOME} | ||
| RUN curl http://192.168.206.113:8000/zeppelin-${VERSION}-bin-all.tgz | tar xvz -C ${ZEPPELIN_HOME} |
There was a problem hiding this comment.
192.168.206.113 is it ip you docker machine? I suggest not good solution use some private ip for get artifacts.
2 participants
No description provided.